Skip to content

Adds confirmation dialog to reset add-on configuration#3945

Closed
ludeeus wants to merge 2 commits into
home-assistant:devfrom
ludeeus:confirm-hassio-config-reset
Closed

Adds confirmation dialog to reset add-on configuration#3945
ludeeus wants to merge 2 commits into
home-assistant:devfrom
ludeeus:confirm-hassio-config-reset

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Oct 6, 2019

This adds:

Closes #3854

Marked as a draft until I get my env up running so I can actually test it.

method: String,
data: {},
disabled: Boolean,
confirmation: String,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a js file with Types in it? 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it, unless I really screwed it up?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah you didn't

Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🦁

@bramkragten
Copy link
Copy Markdown
Member

Managed to test this already? Can't merge it now 😄

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Oct 13, 2019

Not properly :/
I'll take another shot at it after breakfast :)

@bramkragten
Copy link
Copy Markdown
Member

Breakfast? Lunch you mean 😜

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Oct 13, 2019

No matter what I try it fails to build, usually with FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

The changes should work, but since I cannot test it myself I'm closing down this PR.

@ludeeus ludeeus closed this Oct 13, 2019
@bramkragten
Copy link
Copy Markdown
Member

Are you using the latest version of node? try nvm install

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Oct 13, 2019

Tried latest, tried the Dockerfile included in the repo, tried a custom one I have used for other node stuff.

My computer is probably too weak.

If anyone else wants to add this in go for it, just won't be me.
Sorry for wasting your time @bramkragten

@ludeeus ludeeus deleted the confirm-hassio-config-reset branch October 13, 2019 13:57
@bramkragten
Copy link
Copy Markdown
Member

I just tested it, it works ;-)

@iantrich
Copy link
Copy Markdown
Member

@ludeeus you bringing this back?

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Oct 15, 2019

Nope, I've tried multiple computers and none of them will let me test the change.
Without that, I can not be comfortable with adding it myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add confirmation prompt when resetting Hass.io add-on to defaults

5 participants