Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make key_c_hint strings consistent #22971

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

NoRi2909
Copy link
Contributor

At the bottom of setting the ui::tips::key_c_hint shows up in rotation with other hints:

Screenshot 2024-11-23 15 08 27

When you do so the Quick search dialog opens and displays this hint at the bottom:

Screenshot 2024-11-23 15 08 40

The latter should be made consistent with the first by using "command dialog" in both places as "c" maps to "command".

Proposed change

Makes the 'key_c_hint' identical by using:
"Press 'c' on any page to open the command dialog"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Make ui::dialogs::quick-bar::key_c_hint consistent with ui::tips::key_c_hint
@MindFreeze MindFreeze merged commit 999969b into home-assistant:dev Nov 23, 2024
16 checks passed
@NoRi2909 NoRi2909 deleted the patch-20 branch November 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants