Skip to content

Avoid fetching unused stats state column for more info#16141

Merged
bramkragten merged 1 commit into
devfrom
no_state_more_info
Apr 12, 2023
Merged

Avoid fetching unused stats state column for more info#16141
bramkragten merged 1 commit into
devfrom
no_state_more_info

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 12, 2023

Proposed change

Avoid fetching unused statistics state column for more info graphs

I'm not sure we actually graph this as state - the sensor's state at the end of the houris only going to have sparse data so we are selecting a mostly empty column of nulls in most cases which generates additional work on the backend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 49a14a7 into dev Apr 12, 2023
@bramkragten bramkragten deleted the no_state_more_info branch April 12, 2023 08:00
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 12, 2023

thanks

bdraco added a commit that referenced this pull request Apr 26, 2023
piitaya pushed a commit that referenced this pull request Apr 27, 2023
Revert "Avoid fetching unused stats state column for more info (#16141)"

This reverts commit 49a14a7.
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants