Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip and aria-label for ZWave log download #10876

Merged

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion: Unlabeled buttons #3267
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

This is not zwave js, but the old and deprecated zwave panel 😄

@bramkragten bramkragten merged commit 1f67119 into home-assistant:dev Dec 12, 2021
@spacegaier spacegaier deleted the issue-3267-zwave-download-logs branch December 12, 2021 14:57
@spacegaier spacegaier changed the title Fix tooltip and aria-label for ZWave JS log download Fix tooltip and aria-label for ZWave log download Dec 12, 2021
@spacegaier
Copy link
Member Author

This is not zwave js, but the old and deprecated zwave panel 😄

Thanks for pointing that out. Did not realize that 🤦. Follow-up PR to fix that: #10882

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants