-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility regression: cannot click buttons using Home Assistant companion for Android with screen reader #10617
Comments
I never tried the app with a screen reader, but we had made a big change in 2021.11 in regards to the icon buttons specifically to improve the accessibility by ensuring that all (or realistically most) now have an aria-label as confirmed by Chrome Lighthouse tests. Not sure though if that has any link to this issue, since you mention buttons such as "Check config" or "Restart" which are actual text buttons, whereas the change I mentioned is for icon buttons (so no text, purely an icon on the button). Reg "Using Chrome on a desktop I still have buttons twice": You mean in Chrome they are rendered twice or the screen reader is listing/saying them twice (if you can verify that distinction at all)? |
Nice to know this excellent news 🙂 I had not read it in any changelog I read until now.
Can you give me some example I could check to see the difference please? For thermostats for example I have not noticed any change for the two buttons to change mode and the other I don't remind what it does...
By pressing tab key I have them twice, except for "check configuration" even if they are displayed once. For the main reported bug, strangely today I cannot reproduce. The only thing I updated before noticing the change is HACS... |
I still have the two elements but clicking works. |
Checklist
Describe the issue you are experiencing
Using Android Home Assistant app with TalkBack, when going to configuration then server control, I cannot click any button, for example restart or check config.
Moreover, I have every button twice and none can be used.
Using Chrome on a desktop I still have buttons twice but the second one is recognized as a button and can be clicked.
Describe the behavior you expected
I should be able to double-tap the button to activate it.
Steps to reproduce the issue
What version of Home Assistant Core has the issue?
2021.11
What was the last working version of Home Assistant Core?
2021.10
In which browser are you experiencing the issue with?
Home Assistant android app
Which operating system are you using to run this browser?
Android 12
State of relevant entities
No response
Problem-relevant frontend configuration
No response
Javascript errors shown in your browser console/inspector
No response
Additional information
It is a really annoying accessibility regression which make unusable some elements of Home Assistant interface, it looks like others buttons are no more recognized by TalkBack
The text was updated successfully, but these errors were encountered: