Clarify gold level quality scale test requirements#1194
Merged
Conversation
frenck
approved these changes
Jan 24, 2022
ludeeus
reviewed
Jan 24, 2022
| - Entities have device info (if available) ([docs](device_registry_index.md#defining-devices)) | ||
| - Tests for fetching data from the integration and controlling it ([docs](development_testing.md)) | ||
| - Tests | ||
| - Full test coverage for the config flow |
Member
There was a problem hiding this comment.
This is required for all config_flows regardless of quality scale?
Member
There was a problem hiding this comment.
Right, that might be another error. This line was simply moved a bit from above.
Member
Author
There was a problem hiding this comment.
Yes, but if I am not wrong, some of the ones that are already merged are missing coverage. I did not add this as a new requirement, just moved it to the "Tests" section.
allenporter
pushed a commit
to allenporter/developers.home-assistant
that referenced
this pull request
Apr 2, 2022
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Clarify gold level quality scale test requirements as when I read it it was unclear to me that we require tests coverage for all modules, does not change any requirement just make them more clear.
Type of change
Additional information