From 69515c005fbdc2d74b636e98c406868500703ba4 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Wed, 12 Jul 2023 10:29:27 +0200 Subject: [PATCH 1/2] Migrate lock services to support translations --- homeassistant/components/lock/services.yaml | 12 -------- homeassistant/components/lock/strings.json | 32 +++++++++++++++++++++ 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/homeassistant/components/lock/services.yaml b/homeassistant/components/lock/services.yaml index 992c58cf5f6c1..c80517d1fe19c 100644 --- a/homeassistant/components/lock/services.yaml +++ b/homeassistant/components/lock/services.yaml @@ -1,22 +1,16 @@ # Describes the format for available lock services lock: - name: Lock - description: Lock all or specified locks. target: entity: domain: lock fields: code: - name: Code - description: An optional code to lock the lock with. example: 1234 selector: text: open: - name: Open - description: Open all or specified locks. target: entity: domain: lock @@ -24,22 +18,16 @@ open: - lock.LockEntityFeature.OPEN fields: code: - name: Code - description: An optional code to open the lock with. example: 1234 selector: text: unlock: - name: Unlock - description: Unlock all or specified locks. target: entity: domain: lock fields: code: - name: Code - description: An optional code to unlock the lock with. example: 1234 selector: text: diff --git a/homeassistant/components/lock/strings.json b/homeassistant/components/lock/strings.json index da4b5217b8629..cf4f718c8a297 100644 --- a/homeassistant/components/lock/strings.json +++ b/homeassistant/components/lock/strings.json @@ -34,5 +34,37 @@ } } } + }, + "services": { + "lock": { + "name": "Lock", + "description": "Locks a lock.", + "fields": { + "code": { + "name": "Code", + "description": "Code to lock the lock with." + } + } + }, + "open": { + "name": "Open", + "description": "Opens a lock.", + "fields": { + "code": { + "name": "[%key:component::lock::services::lock::fields::code::name%]", + "description": "Code to open the lock with." + } + } + }, + "unlock": { + "name": "Unlock", + "description": "Unlocks a lock.", + "fields": { + "code": { + "name": "[%key:component::lock::services::lock::fields::code::name%]", + "description": "Code to unlock the lock with." + } + } + } } } From 80b0ffaa75e4ce7b3ff9955eb8bf01a34aa49075 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Wed, 12 Jul 2023 16:43:16 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> --- homeassistant/components/lock/strings.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/lock/strings.json b/homeassistant/components/lock/strings.json index cf4f718c8a297..9e20b0cad2bd5 100644 --- a/homeassistant/components/lock/strings.json +++ b/homeassistant/components/lock/strings.json @@ -42,7 +42,7 @@ "fields": { "code": { "name": "Code", - "description": "Code to lock the lock with." + "description": "Code used to lock the lock." } } }, @@ -52,7 +52,7 @@ "fields": { "code": { "name": "[%key:component::lock::services::lock::fields::code::name%]", - "description": "Code to open the lock with." + "description": "Code used to open the lock." } } }, @@ -62,7 +62,7 @@ "fields": { "code": { "name": "[%key:component::lock::services::lock::fields::code::name%]", - "description": "Code to unlock the lock with." + "description": "Code used to unlock the lock." } } }