Skip to content

Support MyStrom ledstrip#95998

Closed
joostlek wants to merge 1 commit into
home-assistant:devfrom
joostlek:mystrom_105
Closed

Support MyStrom ledstrip#95998
joostlek wants to merge 1 commit into
home-assistant:devfrom
joostlek:mystrom_105

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Jul 6, 2023

Proposed change

Using the data in the linked issue and the info on https://api.mystrom.ch I think this device should be supported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mystrom) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mystrom can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mystrom Removes the current integration label and assignees on the pull request, add the integration domain after the command.

device = MyStromSwitch(host)
platforms = PLATFORMS_SWITCH
elif device_type == 102:
elif device_type in [102, 105]:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to myStrom's API documentation:

All the Bulbs request also work on the LED strip

Should be fine as "Light Effects" seems the only difference between the bulb and the strip.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I made this PR to publish the code I wanted someone else to check, as this component was updated in 2023.7.0 and there were some bugs, so I decided to dive into it. I am continuing this in the other PR.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joostlek joostlek closed this Jul 6, 2023
@joostlek joostlek deleted the mystrom_105 branch July 6, 2023 23:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported myStrom device type: 105

2 participants