From 199cefc48f4749b0cba35c242edf20eb14c7c532 Mon Sep 17 00:00:00 2001 From: joostlek Date: Thu, 6 Jul 2023 00:55:12 +0200 Subject: [PATCH 1/3] Add entity translations to Purpleair --- homeassistant/components/purpleair/sensor.py | 22 +++++-------- .../components/purpleair/strings.json | 31 +++++++++++++++++++ 2 files changed, 39 insertions(+), 14 deletions(-) diff --git a/homeassistant/components/purpleair/sensor.py b/homeassistant/components/purpleair/sensor.py index 23370f8a20c2d0..1c65afdcb6e817 100644 --- a/homeassistant/components/purpleair/sensor.py +++ b/homeassistant/components/purpleair/sensor.py @@ -50,7 +50,6 @@ class PurpleAirSensorEntityDescription( SENSOR_DESCRIPTIONS = [ PurpleAirSensorEntityDescription( key="humidity", - name="Humidity", device_class=SensorDeviceClass.HUMIDITY, native_unit_of_measurement=PERCENTAGE, state_class=SensorStateClass.MEASUREMENT, @@ -58,7 +57,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm0.3_count_concentration", - name="PM0.3 count concentration", + translation_key="pm0_3_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -67,7 +66,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm0.5_count_concentration", - name="PM0.5 count concentration", + translation_key="pm0_5_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -76,7 +75,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm1.0_count_concentration", - name="PM1.0 count concentration", + translation_key="pm1_0_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -85,7 +84,6 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm1.0_mass_concentration", - name="PM1.0 mass concentration", device_class=SensorDeviceClass.PM1, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -93,7 +91,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm10.0_count_concentration", - name="PM10.0 count concentration", + translation_key="pm10_0_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -102,7 +100,6 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm10.0_mass_concentration", - name="PM10.0 mass concentration", device_class=SensorDeviceClass.PM10, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -110,7 +107,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm2.5_count_concentration", - name="PM2.5 count concentration", + translation_key="pm2_5_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -119,7 +116,6 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm2.5_mass_concentration", - name="PM2.5 mass concentration", device_class=SensorDeviceClass.PM25, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -127,7 +123,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pm5.0_count_concentration", - name="PM5.0 count concentration", + translation_key="pm5_0_count_concentration", entity_registry_enabled_default=False, icon="mdi:blur", native_unit_of_measurement=CONCENTRATION_PARTICLES_PER_100_MILLILITERS, @@ -136,7 +132,6 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="pressure", - name="Pressure", device_class=SensorDeviceClass.PRESSURE, native_unit_of_measurement=UnitOfPressure.MBAR, state_class=SensorStateClass.MEASUREMENT, @@ -144,7 +139,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="rssi", - name="RSSI", + translation_key="rssi", device_class=SensorDeviceClass.SIGNAL_STRENGTH, entity_category=EntityCategory.DIAGNOSTIC, entity_registry_enabled_default=False, @@ -154,7 +149,6 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="temperature", - name="Temperature", device_class=SensorDeviceClass.TEMPERATURE, native_unit_of_measurement=UnitOfTemperature.FAHRENHEIT, state_class=SensorStateClass.MEASUREMENT, @@ -162,7 +156,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="uptime", - name="Uptime", + translation_key="uptime", entity_category=EntityCategory.DIAGNOSTIC, entity_registry_enabled_default=False, device_class=SensorDeviceClass.DURATION, diff --git a/homeassistant/components/purpleair/strings.json b/homeassistant/components/purpleair/strings.json index 836496d0ca8380..cd71efff0ad693 100644 --- a/homeassistant/components/purpleair/strings.json +++ b/homeassistant/components/purpleair/strings.json @@ -107,5 +107,36 @@ "abort": { "already_configured": "[%key:common::config_flow::abort::already_configured_device%]" } + }, + "entity": { + "sensor": { + "pm0_3_count_concentration": { + "name": "PM0.3 count concentration" + }, + "pm0_5_count_concentration": { + "name": "PM0.5 count concentration" + }, + "pm1_0_count_concentration": { + "name": "PM1.0 count concentration" + }, + "pm10_0_count_concentration": { + "name": "PM10.0 count concentration" + }, + "pm2_5_count_concentration": { + "name": "PM2.5 count concentration" + }, + "pm5_0_count_concentration": { + "name": "PM5.0 count concentration" + }, + "rssi": { + "name": "RSSI" + }, + "uptime": { + "name": "Uptime" + }, + "voc": { + "name": "[%key:component::sensor::entity_component::volatile_organic_compounds::name%]" + } + } } } From 5c3f0a39428dce23ca1e5f7bd17b5563aa2740ce Mon Sep 17 00:00:00 2001 From: joostlek Date: Thu, 6 Jul 2023 00:56:19 +0200 Subject: [PATCH 2/3] Add entity translations to Purpleair --- homeassistant/components/purpleair/sensor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/purpleair/sensor.py b/homeassistant/components/purpleair/sensor.py index 1c65afdcb6e817..cea26fd4702170 100644 --- a/homeassistant/components/purpleair/sensor.py +++ b/homeassistant/components/purpleair/sensor.py @@ -166,7 +166,7 @@ class PurpleAirSensorEntityDescription( ), PurpleAirSensorEntityDescription( key="voc", - name="VOC", + translation_key="voc", device_class=SensorDeviceClass.AQI, state_class=SensorStateClass.MEASUREMENT, value_fn=lambda sensor: sensor.voc, From d5a211f5487ba14f73e10d79b6dae41d22d6d219 Mon Sep 17 00:00:00 2001 From: joostlek Date: Thu, 6 Jul 2023 22:52:05 +0200 Subject: [PATCH 3/3] Change vocaqi sensor --- homeassistant/components/purpleair/sensor.py | 4 ++-- homeassistant/components/purpleair/strings.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/purpleair/sensor.py b/homeassistant/components/purpleair/sensor.py index cea26fd4702170..160f529c285ff2 100644 --- a/homeassistant/components/purpleair/sensor.py +++ b/homeassistant/components/purpleair/sensor.py @@ -165,9 +165,9 @@ class PurpleAirSensorEntityDescription( value_fn=lambda sensor: sensor.uptime, ), PurpleAirSensorEntityDescription( + # This sensor is an air quality index for VOCs. More info at https://github.com/home-assistant/core/pull/84896 key="voc", - translation_key="voc", - device_class=SensorDeviceClass.AQI, + translation_key="voc_aqi", state_class=SensorStateClass.MEASUREMENT, value_fn=lambda sensor: sensor.voc, ), diff --git a/homeassistant/components/purpleair/strings.json b/homeassistant/components/purpleair/strings.json index cd71efff0ad693..5e7c61c182053c 100644 --- a/homeassistant/components/purpleair/strings.json +++ b/homeassistant/components/purpleair/strings.json @@ -134,8 +134,8 @@ "uptime": { "name": "Uptime" }, - "voc": { - "name": "[%key:component::sensor::entity_component::volatile_organic_compounds::name%]" + "voc_aqi": { + "name": "Volatile organic compounds air quality index" } } }