Skip to content

Use slots in TraceElement#95877

Merged
frenck merged 1 commit into
devfrom
trace_element_slots
Jul 5, 2023
Merged

Use slots in TraceElement#95877
frenck merged 1 commit into
devfrom
trace_element_slots

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 4, 2023

Proposed change

If the user has a lot of automations there can be a lot of these floating around in memory. This makes them a bit smaller

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the user has a lot of automations there can be a lot
of these floating around in memory. This makes them a bit
smaller
@home-assistant home-assistant Bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Jul 4, 2023
@bdraco bdraco marked this pull request as ready for review July 4, 2023 21:27
@bdraco bdraco requested a review from a team as a code owner July 4, 2023 21:27
@frenck frenck merged commit 1dfa2f3 into dev Jul 5, 2023
@frenck frenck deleted the trace_element_slots branch July 5, 2023 06:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants