From df4ea120e32fac2a8fe41bbf1e825d18479fb38b Mon Sep 17 00:00:00 2001 From: joostlek Date: Sun, 2 Jul 2023 22:31:50 +0200 Subject: [PATCH 1/2] Add entity translations for Meater --- homeassistant/components/meater/sensor.py | 17 ++++++------ homeassistant/components/meater/strings.json | 28 ++++++++++++++++++++ 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/homeassistant/components/meater/sensor.py b/homeassistant/components/meater/sensor.py index 0a1240c74716ee..d9eea4d83944e8 100644 --- a/homeassistant/components/meater/sensor.py +++ b/homeassistant/components/meater/sensor.py @@ -63,8 +63,8 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Ambient temperature MeaterSensorEntityDescription( key="ambient", + translation_key="ambient", device_class=SensorDeviceClass.TEMPERATURE, - name="Ambient", native_unit_of_measurement=UnitOfTemperature.CELSIUS, state_class=SensorStateClass.MEASUREMENT, available=lambda probe: probe is not None, @@ -73,8 +73,8 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Internal temperature (probe tip) MeaterSensorEntityDescription( key="internal", + translation_key="ambient", device_class=SensorDeviceClass.TEMPERATURE, - name="Internal", native_unit_of_measurement=UnitOfTemperature.CELSIUS, state_class=SensorStateClass.MEASUREMENT, available=lambda probe: probe is not None, @@ -83,7 +83,7 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Name of selected meat in user language or user given custom name MeaterSensorEntityDescription( key="cook_name", - name="Cooking", + translation_key="cook_name", available=lambda probe: probe is not None and probe.cook is not None, value=lambda probe: probe.cook.name if probe.cook else None, ), @@ -91,15 +91,15 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Slightly Underdone, Finished, Slightly Overdone, OVERCOOK!. Not translated. MeaterSensorEntityDescription( key="cook_state", - name="Cook state", + translation_key="cook_state", available=lambda probe: probe is not None and probe.cook is not None, value=lambda probe: probe.cook.state if probe.cook else None, ), # Target temperature MeaterSensorEntityDescription( key="cook_target_temp", + translation_key="cook_target_temp", device_class=SensorDeviceClass.TEMPERATURE, - name="Target", native_unit_of_measurement=UnitOfTemperature.CELSIUS, state_class=SensorStateClass.MEASUREMENT, available=lambda probe: probe is not None and probe.cook is not None, @@ -110,8 +110,8 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Peak temperature MeaterSensorEntityDescription( key="cook_peak_temp", + translation_key="cook_peak_temp", device_class=SensorDeviceClass.TEMPERATURE, - name="Peak", native_unit_of_measurement=UnitOfTemperature.CELSIUS, state_class=SensorStateClass.MEASUREMENT, available=lambda probe: probe is not None and probe.cook is not None, @@ -123,8 +123,8 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Exposed as a TIMESTAMP sensor where the timestamp is current time + remaining time. MeaterSensorEntityDescription( key="cook_time_remaining", + translation_key="cook_time_remaining", device_class=SensorDeviceClass.TIMESTAMP, - name="Remaining time", available=lambda probe: probe is not None and probe.cook is not None, value=_remaining_time_to_timestamp, ), @@ -132,8 +132,8 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # where the timestamp is current time - elapsed time. MeaterSensorEntityDescription( key="cook_time_elapsed", + translation_key="cook_time_elapsed", device_class=SensorDeviceClass.TIMESTAMP, - name="Elapsed time", available=lambda probe: probe is not None and probe.cook is not None, value=_elapsed_time_to_timestamp, ), @@ -191,7 +191,6 @@ def __init__( ) -> None: """Initialise the sensor.""" super().__init__(coordinator) - self._attr_name = f"Meater Probe {description.name}" self._attr_device_info = { "identifiers": { # Serial numbers are unique identifiers within a specific domain diff --git a/homeassistant/components/meater/strings.json b/homeassistant/components/meater/strings.json index 7f4a97a5b19c5a..279841bb14777c 100644 --- a/homeassistant/components/meater/strings.json +++ b/homeassistant/components/meater/strings.json @@ -26,5 +26,33 @@ "unknown_auth_error": "[%key:common::config_flow::error::unknown%]", "service_unavailable_error": "The API is currently unavailable, please try again later." } + }, + "entity": { + "sensor": { + "ambient": { + "name": "Ambient temperature" + }, + "internal": { + "name": "Internal temperature" + }, + "cook_name": { + "name": "Cooking" + }, + "cook_state": { + "name": "Cook state" + }, + "cook_target_temp": { + "name": "Target temperature" + }, + "cook_peak_temp": { + "name": "Peak temperature" + }, + "cook_time_remaining": { + "name": "Time remaining" + }, + "cook_time_elapsed": { + "name": "Time elapsed" + } + } } } From a7071c0443c1a8424b10eded4bc281bee62ed790 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Sun, 2 Jul 2023 21:37:53 -0400 Subject: [PATCH 2/2] Update homeassistant/components/meater/sensor.py --- homeassistant/components/meater/sensor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/meater/sensor.py b/homeassistant/components/meater/sensor.py index d9eea4d83944e8..eef19f3fc92701 100644 --- a/homeassistant/components/meater/sensor.py +++ b/homeassistant/components/meater/sensor.py @@ -73,7 +73,7 @@ def _remaining_time_to_timestamp(probe: MeaterProbe) -> datetime | None: # Internal temperature (probe tip) MeaterSensorEntityDescription( key="internal", - translation_key="ambient", + translation_key="internal", device_class=SensorDeviceClass.TEMPERATURE, native_unit_of_measurement=UnitOfTemperature.CELSIUS, state_class=SensorStateClass.MEASUREMENT,