Add Matter Climate support by hidaris · Pull Request #95434 · home-assistant/core

hidaris · 2023-06-28T08:42:56Z

Breaking change

Proposed change

Add Matter Climate support

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add climate platform to Matter docs home-assistant.io#28009

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-06-28T08:43:02Z

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

marcelveldt · 2023-06-29T20:40:05Z

@hidaris I've updated the code and tests. Only thing I wanted to ask is if its also possible to put the device in auto mode or is that only passive ? As I can see that the device can be in auto mode but its not a mode we can set it to as it seems.

MartinHjelmare

Looks good! We need some more test coverage.

hidaris · 2023-07-01T14:20:14Z

I think this PR is almost complete. I have some doubts about constructing test cases for properties like target temp and min temp when they are set to None. In such cases, it seems that I have to adjust the matter fixture to accommodate it, even though there is a default value for the set point in the matter spec. Is there a better way to handle this? I am currently not sure

MartinHjelmare · 2023-07-02T09:21:46Z

If the case where max and min returns None can't happen, we can raise RuntimeError to indicate a developer mistake. We don't need to test that.

MartinHjelmare

Thanks!

hidaris · 2023-07-03T10:41:00Z

Thanks for your reviews and help!

craigwitter · 2023-07-03T10:50:19Z

Thank you for doing this change!!

* Add Matter Climate support * update set target temp and update callback * remove print * remove optional property * Adjust the code to improve readability. * add thermostat test * Remove irrelevant cases in setting the target temperature. * add temp range support * update hvac action * support adjust low high setpoint.. * support set hvac mode * address some review feedback * move some methods around * dont discover climate in switch platform * set some default values * fix some of the tests * fix some typos * Update thermostat.json * Update homeassistant/components/matter/climate.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Update homeassistant/components/matter/climate.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * support heat_cool in hvac_modes * address some review feedback * handle hvac mode param in set temp service * check hvac modes by featuremap * add comment to thermostat feature class * make ruff happy.. * use enum to enhance readability. * use builtin feature bitmap * fix target temp range and address some feedback * use instance attribute instead of class attr * make ruff happy... * address feedback about single case * add init docstring * more test * fix typo in tests * make ruff happy * fix hvac modes test * test case for update callback * remove optional check * more tests * more tests * update all attributes in the update callback * Update climate.py * fix missing test --------- Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

hidaris requested a review from a team as a code owner June 28, 2023 08:42

home-assistant Bot added cla-signed integration: matter new-feature new-platform labels Jun 28, 2023

home-assistant Bot added the Quality Scale: No score label Jun 28, 2023

marcelveldt marked this pull request as draft June 28, 2023 08:46

MartinHjelmare reviewed Jun 29, 2023

View reviewed changes

marcelveldt mentioned this pull request Jun 29, 2023

Add climate platform to Matter docs home-assistant/home-assistant.io#28009

Merged

8 tasks

MartinHjelmare reviewed Jun 29, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py Outdated

Comment thread homeassistant/components/matter/climate.py Outdated

Comment thread homeassistant/components/matter/climate.py Outdated

hidaris added 11 commits June 29, 2023 22:52

Add Matter Climate support

a5c192b

update set target temp and update callback

664dfd5

remove print

d9a4fb9

remove optional property

3a196f6

Adjust the code to improve readability.

c5ead46

add thermostat test

22bad2f

Remove irrelevant cases in setting the target temperature.

6678f86

add temp range support

be999ee

update hvac action

be97a5b

support adjust low high setpoint..

8ef77fd

support set hvac mode

aa7b355

hidaris force-pushed the draft_climate_support branch from ddcf422 to aa7b355 Compare June 29, 2023 14:52

marcelveldt added 6 commits June 29, 2023 22:00

address some review feedback

ba604d0

move some methods around

62533d2

dont discover climate in switch platform

85ea3a5

set some default values

9859164

fix some of the tests

5ae774b

fix some typos

d9bd12b

MartinHjelmare reviewed Jul 1, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py Outdated

hidaris added 3 commits July 1, 2023 16:04

make ruff happy...

d65d75e

address feedback about single case

261557b

add init docstring

b4d2c5f

MartinHjelmare reviewed Jul 1, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py Outdated

hidaris added 4 commits July 1, 2023 16:38

more test

74707b7

fix typo in tests

d1d659b

make ruff happy

93269dc

fix hvac modes test

157e108

hidaris commented Jul 1, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py

hidaris added 3 commits July 1, 2023 18:51

test case for update callback

3c71390

remove optional check

02330ab

more tests

d0c1662

hidaris commented Jul 1, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py

hidaris and others added 2 commits July 2, 2023 17:47

more tests

95579a2

update all attributes in the update callback

bb427c2

marcelveldt marked this pull request as ready for review July 3, 2023 08:25

MartinHjelmare reviewed Jul 3, 2023

View reviewed changes

Comment thread homeassistant/components/matter/climate.py Outdated

Comment thread homeassistant/components/matter/climate.py

marcelveldt added 2 commits July 3, 2023 11:02

Update climate.py

875d176

fix missing test

7f022c7

MartinHjelmare approved these changes Jul 3, 2023

View reviewed changes

MartinHjelmare merged commit 3bd8955 into home-assistant:dev Jul 3, 2023

balloob added this to the 2023.7.0 milestone Jul 3, 2023

balloob added the cherry-picked label Jul 3, 2023

github-actions Bot locked and limited conversation to collaborators Jul 4, 2023

Uh oh!

Conversation

hidaris commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Jun 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcelveldt commented Jun 29, 2023

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hidaris commented Jul 1, 2023

Uh oh!

MartinHjelmare commented Jul 2, 2023

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

hidaris commented Jul 3, 2023

Uh oh!

craigwitter commented Jul 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hidaris commented Jun 28, 2023 •

edited

Loading