Skip to content

Add Airzone Cloud Binary Sensors support#93583

Merged
gjohansson-ST merged 15 commits into
home-assistant:devfrom
Noltari:airzone-cloud-binary-sensors
Jun 23, 2023
Merged

Add Airzone Cloud Binary Sensors support#93583
gjohansson-ST merged 15 commits into
home-assistant:devfrom
Noltari:airzone-cloud-binary-sensors

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented May 26, 2023

Proposed change

Add Binary Sensors to Airzone Cloud integration.
As a first step, just add the Binary Sensors for the Airzone Zones. More binary sensors will be added in the future for WebServer, Systems and Aidoos.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as draft May 26, 2023 08:06
@Noltari Noltari marked this pull request as ready for review May 26, 2023 08:13
Noltari added 3 commits May 29, 2023 11:11
This is not working as expected and will require minor library changes.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as draft May 29, 2023 21:27
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as ready for review May 30, 2023 05:37
Comment thread homeassistant/components/airzone_cloud/binary_sensor.py Outdated
Comment thread homeassistant/components/airzone_cloud/binary_sensor.py
Comment thread homeassistant/components/airzone_cloud/binary_sensor.py
@home-assistant home-assistant Bot marked this pull request as draft June 20, 2023 20:34
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Noltari added 3 commits June 21, 2023 08:46
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as ready for review June 22, 2023 09:28
@home-assistant home-assistant Bot requested a review from gjohansson-ST June 22, 2023 09:28
Noltari added 2 commits June 22, 2023 23:16
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last tiny bit

Comment thread homeassistant/components/airzone_cloud/binary_sensor.py
Comment thread homeassistant/components/airzone_cloud/binary_sensor.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft June 23, 2023 13:39
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@Noltari Noltari force-pushed the airzone-cloud-binary-sensors branch from 90a33ed to 164dd69 Compare June 23, 2023 14:11
@Noltari Noltari marked this pull request as ready for review June 23, 2023 14:15
@home-assistant home-assistant Bot requested a review from gjohansson-ST June 23, 2023 14:15
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jun 23, 2023

Last tiny bit

Done :)

@gjohansson-ST gjohansson-ST merged commit cd66da0 into home-assistant:dev Jun 23, 2023
@Noltari Noltari deleted the airzone-cloud-binary-sensors branch June 23, 2023 14:41
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jun 23, 2023

Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants