Add new config variable to MQTT light#9304
Merged
Merged
Conversation
Contributor
pvizeli
requested changes
Sep 5, 2017
|
|
||
| rgb_color_str = '{},{},{}'.format(*kwargs[ATTR_RGB_COLOR]) | ||
| tpl = self._templates[CONF_RGB_COMMAND_TEMPLATE] | ||
| if tpl is not None: |
Member
There was a problem hiding this comment.
Use:
if tpl...:
...
rgb_color_str = ...
else:
rgb_color_str = ...
| colors = {'red', 'green', 'blue'} | ||
| env = {} | ||
| for key, val in zip(colors, kwargs[ATTR_RGB_COLOR]): | ||
| env[key] = val |
Member
There was a problem hiding this comment.
Add this in same statment:
variables = {key: val for key, val in zip(...)}
Contributor
Author
|
Pascal, thank you for review. |
pvizeli
approved these changes
Sep 5, 2017
Member
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: MQTT Light - New config variable rgb_command_template
Some devices do not understand Home Assistance default RGB format. The idea of this PR is to let user ability to control RGB color format in the same way as variables like rgb_value_template do.
**Pull request in home-assistant.github.io with documentation: PR 3312
Example entry for
light.yaml:Use HEX RGB color format:
Topic message will be like
#ffddeeChecklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass