From 65f56b6b12213d1f56c54f9866a1f74362f75e8a Mon Sep 17 00:00:00 2001 From: joostlek Date: Sun, 30 Apr 2023 14:50:11 +0200 Subject: [PATCH 1/2] Move constant values to separate file --- homeassistant/components/lastfm/const.py | 15 +++++++++++++++ homeassistant/components/lastfm/sensor.py | 18 ++++++++---------- 2 files changed, 23 insertions(+), 10 deletions(-) create mode 100644 homeassistant/components/lastfm/const.py diff --git a/homeassistant/components/lastfm/const.py b/homeassistant/components/lastfm/const.py new file mode 100644 index 00000000000000..2a7f40b99e3a33 --- /dev/null +++ b/homeassistant/components/lastfm/const.py @@ -0,0 +1,15 @@ +"""Constants for LastFM.""" +import logging +from typing import Final + +LOGGER = logging.getLogger(__package__) +DOMAIN: Final = "lastfm" +DEFAULT_NAME = "LastFM" + +CONF_USERS = "users" + +ATTR_LAST_PLAYED = "last_played" +ATTR_PLAY_COUNT = "play_count" +ATTR_TOP_PLAYED = "top_played" + +STATE_NOT_SCROBBLING = "Not Scrobbling" diff --git a/homeassistant/components/lastfm/sensor.py b/homeassistant/components/lastfm/sensor.py index a25171f9c2ed8a..20c51f8a8c6a3b 100644 --- a/homeassistant/components/lastfm/sensor.py +++ b/homeassistant/components/lastfm/sensor.py @@ -2,7 +2,6 @@ from __future__ import annotations import hashlib -import logging from pylast import LastFMNetwork, Track, User, WSError import voluptuous as vol @@ -14,15 +13,14 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.typing import ConfigType, DiscoveryInfoType -LOGGER = logging.getLogger(__name__) - -CONF_USERS = "users" - -ATTR_LAST_PLAYED = "last_played" -ATTR_PLAY_COUNT = "play_count" -ATTR_TOP_PLAYED = "top_played" - -STATE_NOT_SCROBBLING = "Not Scrobbling" +from .const import ( + ATTR_LAST_PLAYED, + ATTR_PLAY_COUNT, + ATTR_TOP_PLAYED, + CONF_USERS, + LOGGER, + STATE_NOT_SCROBBLING, +) PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend( { From 06b98b3029b5bd3ae69242a80f1d250ebd8e168d Mon Sep 17 00:00:00 2001 From: joostlek Date: Sun, 30 Apr 2023 14:51:50 +0200 Subject: [PATCH 2/2] Move constant values to separate file --- tests/components/lastfm/test_sensor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/components/lastfm/test_sensor.py b/tests/components/lastfm/test_sensor.py index 0fa45a1227783f..d9de78b8f8a4ea 100644 --- a/tests/components/lastfm/test_sensor.py +++ b/tests/components/lastfm/test_sensor.py @@ -5,7 +5,7 @@ import pytest from homeassistant.components import sensor -from homeassistant.components.lastfm.sensor import STATE_NOT_SCROBBLING +from homeassistant.components.lastfm.const import STATE_NOT_SCROBBLING from homeassistant.core import HomeAssistant from homeassistant.setup import async_setup_component