Skip to content

Let MQTT availability for snips be managed by dependencies#91790

Merged
jbouwh merged 1 commit into
home-assistant:devfrom
jbouwh:snips-remove-mqtt-check
Apr 21, 2023
Merged

Let MQTT availability for snips be managed by dependencies#91790
jbouwh merged 1 commit into
home-assistant:devfrom
jbouwh:snips-remove-mqtt-check

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Apr 21, 2023

Proposed change

Since #81733 the snips integration has been leaning on checks if MQTT was started up. Since HA should manage the dependencies for integrations, (improvements were made with #91454) it should be safe now now to re move the check for MQTT availability and waiting for mqtt te become available.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jbouwh jbouwh merged commit 92bb61d into home-assistant:dev Apr 21, 2023
@jbouwh jbouwh deleted the snips-remove-mqtt-check branch April 21, 2023 07:05
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants