volvooncall: Handle the case where no registration number is returned by the API for a vehicle.#9073
Merged
Merged
Conversation
|
@molobrakos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @palp and @pvizeli to be potential reviewers. |
Contributor
|
Is it possible to add at least partial tests? |
balloob
reviewed
Aug 23, 2017
Member
There was a problem hiding this comment.
This code could really benefit from being rewritten as if…elsif statements.
molobrakos
force-pushed
the
voc-regno-fix
branch
from
ff0fd35 to
4bc11f4
Compare
houndci-bot
reviewed
Aug 29, 2017
There was a problem hiding this comment.
visually indented line with same indent as next logical line
…splay VIN (vehicle identification number)).
molobrakos
force-pushed
the
voc-regno-fix
branch
from
4bc11f4 to
ff0ca50
Compare
Merged
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead display VIN (vehicle identification number).
Closes molobrakos/volvooncall#9
Also extract component state into a data class.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass