Skip to content

Follow Twitter guidelines for media upload by conforming to the "STAT…#8992

Closed
MikeChristianson wants to merge 3 commits into
home-assistant:devfrom
MikeChristianson:twitter-improved-media-upload
Closed

Follow Twitter guidelines for media upload by conforming to the "STAT…#8992
MikeChristianson wants to merge 3 commits into
home-assistant:devfrom
MikeChristianson:twitter-improved-media-upload

Conversation

@MikeChristianson
Copy link
Copy Markdown
Contributor

@MikeChristianson MikeChristianson commented Aug 15, 2017 •
edited
Loading

Building on the Twitter notification support added in #8282:

Follow Twitter guidelines for media upload by conforming to the "STATUS" phase, when required, and by providing "media_category" information. These changes will, for example, allow users to upload videos that exceed the basic 30 second limit.

notify:
  - name: twitter
    platform: twitter
    consumer_key: …
    consumer_secret: …
    access_token: …
    access_token_secret: …

automation twitter:
  alias: Send a test message
  initial_state: True
  hide_entity: False
  trigger:
    platform: homeassistant
    event: start
  action:
    - service: notify.twitter
      data:
        message: "Test at {{ now().strftime('%I:%M:%S %p') }}."
        data:
          media: /tmp/my-awesome-video.mp4
#          media: /tmp/my-awesome-gif.gif
#          media: /tmp/my-awesome-image.jpg
    - service: homeassistant.turn_off
      entity_id: automation.send_a_test_message

@MikeChristianson
Follow Twitter guidelines for media upload by conforming to the "STAT…
44d99f9 
…US" phase, when required, and by providing "media_category" information. These will, for example, allow users to upload videos that exceed the basic 30 second limit.

See:
 - https://twittercommunity.com/t/media-category-values/64781/7
 - https://twittercommunity.com/t/duration-too-long-maximim-30000/68760
 - https://dev.twitter.com/rest/reference/get/media/upload-status.html
@mention-bot
Copy link
Copy Markdown

mention-bot commented Aug 15, 2017

@MikeChristianson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @HydrelioxGitHub and @pvizeli to be potential reviewers.

pvizeli
pvizeli requested changes Aug 16, 2017
View reviewed changes
Comment thread homeassistant/components/notify/twitter.py
_LOGGER.debug("media processing waiting %s seconds to check status",
str(check_after_secs))

time.sleep(check_after_secs)
Copy link
Copy Markdown
Member

@pvizeli pvizeli Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not use sleep for that. Use helper/events.py to shedule a callback.

Copy link
Copy Markdown
Contributor Author

@MikeChristianson MikeChristianson Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvizeli I'm not sure how to use helpers/event.py. Could you point me to an example in the hass codebase? (I'm coming up empty.)

Copy link
Copy Markdown
Member

@pvizeli pvizeli Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/event.py#L117 like that or the UTC version.

@andrey-git
Copy link
Copy Markdown
Contributor

andrey-git commented Aug 22, 2017

@MikeChristianson any updates on this PR?

@MikeChristianson
Copy link
Copy Markdown
Contributor Author

MikeChristianson commented Aug 23, 2017

@andrey-git In progress, slowly.

@MikeChristianson
Copy link
Copy Markdown
Contributor Author

MikeChristianson commented Aug 26, 2017

I'm having difficulty implementing the changes requested. I'm closing this PR until I have demonstrable progress.

@MikeChristianson MikeChristianson mentioned this pull request Sep 2, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pvizeli pvizeli pvizeli requested changes

Assignees

No one assigned

Labels

cla-signed integration: twitter platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MikeChristianson @mention-bot @andrey-git @pvizeli @balloobbot @homeassistant