Skip to content

Bump requests to 2.28.2#88956

Merged
frenck merged 6 commits into
home-assistant:devfrom
mitch-dc:patch-1
Mar 1, 2023
Merged

Bump requests to 2.28.2#88956
frenck merged 6 commits into
home-assistant:devfrom
mitch-dc:patch-1

Conversation

@mitch-dc
Copy link
Copy Markdown
Contributor

@mitch-dc mitch-dc commented Mar 1, 2023

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

Comment thread requirements.txt
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 1, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft March 1, 2023 08:38
@MartinHjelmare MartinHjelmare changed the title Bumped requests package to 2.28.2 Bump requests to 2.28.2 Mar 1, 2023
@mitch-dc mitch-dc marked this pull request as ready for review March 1, 2023 08:48
@mitch-dc mitch-dc requested a review from a team as a code owner March 1, 2023 08:48
@home-assistant home-assistant Bot requested a review from MartinHjelmare March 1, 2023 08:48
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Mar 1, 2023

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

Please solve this too, thanks! ☝️

There are check boxes in the PR description to check off where this is requested too.

@mitch-dc
Copy link
Copy Markdown
Contributor Author

mitch-dc commented Mar 1, 2023

Added psf/requests@v2.28.1...v2.28.2 to description

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Mar 1, 2023

We need to bump nuheat to 1.0.1 in a separate PR to solve the conflict for requests.

broox/python-nuheat@1.0.0...1.0.1

Can you do that? There are no logic changes in 1.0.1 besides the loosening of the requirement pinning for requests.

@mitch-dc
Copy link
Copy Markdown
Contributor Author

mitch-dc commented Mar 1, 2023

1.0.1

#88958

@MartinHjelmare
Copy link
Copy Markdown
Member

Have you tested an integration that uses requests with this version of requests in Home Assistant?

@mitch-dc
Copy link
Copy Markdown
Contributor Author

mitch-dc commented Mar 1, 2023

Have you tested an integration that uses requests with this version of requests in Home Assistant?

Yes!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mitch-dc 👍

../Frenck

@frenck frenck merged commit 341d046 into home-assistant:dev Mar 1, 2023
@jonas-wilnerzon
Copy link
Copy Markdown

@MartinHjelmare @frenck In which upcoming release do you think this change will be included?

@MartinHjelmare
Copy link
Copy Markdown
Member

At the moment it's targeted for the April release.

@jonas-wilnerzon
Copy link
Copy Markdown

@MartinHjelmare Alright, thanks!

@mitch-dc
Copy link
Copy Markdown
Contributor Author

mitch-dc commented Mar 2, 2023

@MartinHjelmare Any posibillity to include in the next .1 release? It's breaking for a custom component that a lot of people use.
I'm working on making the component ready to include in core but time is not on my side.

https://github.com/mitch-dc/volkswagen_we_connect_id/issues

@MartinHjelmare
Copy link
Copy Markdown
Member

Yes, we've tagged it for the next patch release now.

balloob pushed a commit that referenced this pull request Mar 2, 2023
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Mar 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants