Bump requests to 2.28.2#88956
Conversation
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Please solve this too, thanks! ☝️ There are check boxes in the PR description to check off where this is requested too. |
|
Added psf/requests@v2.28.1...v2.28.2 to description |
|
We need to bump broox/python-nuheat@1.0.0...1.0.1 Can you do that? There are no logic changes in 1.0.1 besides the loosening of the requirement pinning for |
|
|
Have you tested an integration that uses requests with this version of requests in Home Assistant? |
Yes! |
|
@MartinHjelmare @frenck In which upcoming release do you think this change will be included? |
|
At the moment it's targeted for the April release. |
|
@MartinHjelmare Alright, thanks! |
|
@MartinHjelmare Any posibillity to include in the next .1 release? It's breaking for a custom component that a lot of people use. https://github.com/mitch-dc/volkswagen_we_connect_id/issues |
|
Yes, we've tagged it for the next patch release now. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: