Skip to content

Revert "Add state_class = MEASUREMENT to Derivative sensor (#88408)"#88952

Merged
frenck merged 1 commit into
devfrom
revert_derivative_state_class
Mar 1, 2023
Merged

Revert "Add state_class = MEASUREMENT to Derivative sensor (#88408)"#88952
frenck merged 1 commit into
devfrom
revert_derivative_state_class

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Mar 1, 2023

Proposed change

This reverts commit fa2e7aa (#88408).

We need to disable statistics for the derivative sensor because it has multiple issues:

  • Derivative sensor's restore state is not restoring the native_value
  • Derivative sensor's restore state does not restore the unit (this is why the recorder complains in the linked issue)
  • Derivate sensor doesn't set its state to unknown or unavailable when the input sensor is unknown or unavailable, the state just stops updating

For a future release, we should fix the issues and enable statistics for the derivative sensor again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2023.3.0 milestone Mar 1, 2023
@home-assistant home-assistant Bot added cla-signed has-tests integration: derivative merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. Quality Scale: No score labels Mar 1, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 1, 2023

Hey there @afaucogney, mind taking a look at this pull request as it has been labeled with an integration (derivative) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of derivative can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign derivative Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery emontnemery changed the base branch from rc to dev March 1, 2023 07:42
@emontnemery emontnemery force-pushed the revert_derivative_state_class branch from eec45f7 to 87d9136 Compare March 1, 2023 07:42
@emontnemery emontnemery removed the merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. label Mar 1, 2023
@frenck frenck merged commit 9ab95b6 into dev Mar 1, 2023
@frenck frenck deleted the revert_derivative_state_class branch March 1, 2023 07:53
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derivative sensor unit dropped

2 participants