Skip to content

Selector with multiple device class#88612

Closed
rokam wants to merge 2 commits into
home-assistant:devfrom
rokam:features/multiple_selector
Closed

Selector with multiple device class#88612
rokam wants to merge 2 commits into
home-assistant:devfrom
rokam:features/multiple_selector

Conversation

@rokam
Copy link
Copy Markdown
Contributor

@rokam rokam commented Feb 22, 2023

Proposed change

Enabled selector with multiple device_classes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This change in the frontend enables this feature: home-assistant/frontend#15302
Feature request: https://community.home-assistant.io/t/support-multiple-classes-in-selector/323126/2

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Feb 22, 2023
@rokam rokam changed the title feat(selector): enable multiple class selection Selector with multiple device class Feb 22, 2023
@rokam rokam marked this pull request as ready for review February 22, 2023 17:56
@rokam rokam requested a review from a team as a code owner February 22, 2023 17:56
@piitaya
Copy link
Copy Markdown
Member

piitaya commented Feb 22, 2023

Hello 👋
There is another PR open for this : #87536
domain, device_class and integration move to a filter array so you can have something like this :

{
  "entity": {
    "filter": [
      { "domain": "input_datetime" },
      { "domain": "binary_sensor", "device_class": ["door", "motion"] },
    ]
  }
}

@rokam
Copy link
Copy Markdown
Contributor Author

rokam commented Feb 22, 2023

Same feature as: #87536

@rokam rokam closed this Feb 22, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants