Skip to content

Rename mock_setup_entry fixture#88481

Closed
epenet wants to merge 2 commits into
home-assistant:devfrom
epenet:mock_setup_entry
Closed

Rename mock_setup_entry fixture#88481
epenet wants to merge 2 commits into
home-assistant:devfrom
epenet:mock_setup_entry

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Feb 20, 2023

Proposed change

Adjust fixture naming for mock_setup_entry
Based on review comment #88319 (comment)

cc @frenck, @emontnemery

WARNING: this is an alternative to #88484

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet changed the title Adjust mock_setup_entry for config flow Rename mock_setup_entry fixture Feb 20, 2023
@epenet epenet marked this pull request as draft February 20, 2023 15:50
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 6, 2023

Closing in favor of #88484

@frenck frenck closed this Mar 6, 2023
@epenet epenet deleted the mock_setup_entry branch March 6, 2023 10:32
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants