Skip to content

Add mV as a unit for voltage and enable conversions #84805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 7 commits into from
Dec 30, 2022
Merged

Add mV as a unit for voltage and enable conversions #84805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6938826
Accept mV and mA as valid units
jbouwh Dec 29, 2022
f3c5ffe
Add mA to the docstring
jbouwh Dec 29, 2022
7e7e968
Only implement mV as new unit_of_measurement
jbouwh Dec 29, 2022
916d73c
Correct conversion factor and test
jbouwh Dec 29, 2022
e6614b8
Correct unit
jbouwh Dec 29, 2022
ced902e
Remove redundant test
jbouwh Dec 29, 2022
c5a0e0d
Not needed as superseeded by #84808
jbouwh Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/number/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ class NumberDeviceClass(StrEnum):
VOLTAGE = "voltage"
"""Voltage.

Unit of measurement: `V`
Unit of measurement: `V`, `mV`
"""

VOLUME = "volume"
Expand Down
6 changes: 4 additions & 2 deletions homeassistant/components/sensor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
BaseUnitConverter,
DataRateConverter,
DistanceConverter,
ElectricPotentialConverter,
InformationConverter,
MassConverter,
PressureConverter,
Expand Down Expand Up @@ -390,7 +391,7 @@ class SensorDeviceClass(StrEnum):
VOLTAGE = "voltage"
"""Voltage.

Unit of measurement: `V`
Unit of measurement: `V`, `mV`
"""

VOLUME = "volume"
Expand Down Expand Up @@ -476,6 +477,7 @@ class SensorStateClass(StrEnum):
SensorDeviceClass.PRESSURE: PressureConverter,
SensorDeviceClass.SPEED: SpeedConverter,
SensorDeviceClass.TEMPERATURE: TemperatureConverter,
SensorDeviceClass.VOLTAGE: ElectricPotentialConverter,
SensorDeviceClass.VOLUME: VolumeConverter,
SensorDeviceClass.WATER: VolumeConverter,
SensorDeviceClass.WEIGHT: MassConverter,
Expand Down Expand Up @@ -537,7 +539,7 @@ class SensorStateClass(StrEnum):
SensorDeviceClass.VOLATILE_ORGANIC_COMPOUNDS: {
CONCENTRATION_MICROGRAMS_PER_CUBIC_METER
},
SensorDeviceClass.VOLTAGE: {UnitOfElectricPotential.VOLT},
SensorDeviceClass.VOLTAGE: set(UnitOfElectricPotential),
SensorDeviceClass.VOLUME: set(UnitOfVolume),
SensorDeviceClass.WATER: {
UnitOfVolume.CENTUM_CUBIC_FEET,
Expand Down
16 changes: 16 additions & 0 deletions homeassistant/util/unit_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from homeassistant.const import (
UNIT_NOT_RECOGNIZED_TEMPLATE,
UnitOfDataRate,
UnitOfElectricPotential,
UnitOfEnergy,
UnitOfInformation,
UnitOfLength,
Expand Down Expand Up @@ -137,6 +138,21 @@ class DistanceConverter(BaseUnitConverter):
}


class ElectricPotentialConverter(BaseUnitConverter):
"""Utility to convert electric potential values."""

UNIT_CLASS = "voltage"
NORMALIZED_UNIT = UnitOfElectricPotential.VOLT
_UNIT_CONVERSION: dict[str, float] = {
UnitOfElectricPotential.VOLT: 1,
UnitOfElectricPotential.MILLIVOLT: 1e3,
}
VALID_UNITS = {
UnitOfElectricPotential.VOLT,
UnitOfElectricPotential.MILLIVOLT,
}


class EnergyConverter(BaseUnitConverter):
"""Utility to convert energy values."""

Expand Down