Skip to content

Fix harmony#8302

Merged
balloob merged 2 commits into
devfrom
fix-harmony
Jul 2, 2017
Merged

Fix harmony#8302
balloob merged 2 commits into
devfrom
fix-harmony

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jul 2, 2017

Description:

Related issue (if applicable): fixes #8293

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @everix1992 and @tony2nite to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Jul 2, 2017

@balloob balloob merged commit 3a6434f into dev Jul 2, 2017
@balloob balloob deleted the fix-harmony branch July 2, 2017 20:05
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Jul 5, 2017

Cherry picked for 0.48.1

balloob added a commit that referenced this pull request Jul 5, 2017
* Fix harmony

* Fix 1 reference
@balloob balloob mentioned this pull request Jul 5, 2017
@balloob balloob mentioned this pull request Jul 13, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Fix harmony

* Fix 1 reference
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error setting up Harmony platform

4 participants