Skip to content

further document zwave add_node_secure#8229

Merged
andrey-git merged 1 commit into
home-assistant:devfrom
JudgeDreddKLC:patch-1
Jun 30, 2017
Merged

further document zwave add_node_secure#8229
andrey-git merged 1 commit into
home-assistant:devfrom
JudgeDreddKLC:patch-1

Conversation

@JudgeDreddKLC
Copy link
Copy Markdown
Contributor

@JudgeDreddKLC JudgeDreddKLC commented Jun 28, 2017

added documentation to attempt explanation that add_node_secure will also function for adding unsecure nodes.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

added documentation to *attempt* explanation that add_node_secure will also function for adding unsecure nodes.
@mention-bot
Copy link
Copy Markdown

@kentcalero, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrey-git, @turbokongen and @armills to be potential reviewers.

@andrey-git
Copy link
Copy Markdown
Contributor

Thanks!

@andrey-git andrey-git merged commit 33fd225 into home-assistant:dev Jun 30, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
added documentation to *attempt* explanation that add_node_secure will also function for adding unsecure nodes.
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants