Skip to content

Restore color_temp handling for lifx.set_state#82067

Merged
bdraco merged 1 commit into
home-assistant:devfrom
Djelibeybi:lifx-color-temp
Nov 14, 2022
Merged

Restore color_temp handling for lifx.set_state#82067
bdraco merged 1 commit into
home-assistant:devfrom
Djelibeybi:lifx-color-temp

Conversation

@Djelibeybi
Copy link
Copy Markdown
Contributor

Proposed change

Restore handling of color_temp by the lifx.set_state service.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Avi Miller <me@dje.li>
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (lifx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lifx can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign lifx Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco merged commit 4265287 into home-assistant:dev Nov 14, 2022
@bdraco bdraco added this to the 2022.11.3 milestone Nov 14, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 15, 2022
@Djelibeybi Djelibeybi deleted the lifx-color-temp branch July 25, 2024 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lifx.set_state 2022.11 issues

3 participants