Added buienradar precipitation forecast average & total sensors#8171
Merged
balloob merged 6 commits intoJun 24, 2017
Conversation
houndci-bot
reviewed
Jun 23, 2017
|
|
||
| # rounding coordinates prevents unnecessary redirects/calls | ||
| rainurl = 'http://gadgets.buienradar.nl/data/raintext/?lat={}&lon={}'.format( | ||
| round(self.coordinates[CONF_LATITUDE], 2), |
| content = yield from self.get_data('http://api.buienradar.nl') | ||
|
|
||
| # rounding coordinates prevents unnecessary redirects/calls | ||
| rainurl = 'http://gadgets.buienradar.nl/data/raintext/?lat={}&lon={}'.format( |
There was a problem hiding this comment.
line too long (85 > 79 characters)
| def async_update(self, *_): | ||
| """Update the data from buienradar.""" | ||
| from buienradar.buienradar import (parse_data, CONTENT, | ||
| from buienradar.buienradar import (parse_data, CONTENT, RAINCONTENT, |
There was a problem hiding this comment.
'buienradar.buienradar.RAINCONTENT' imported but unused
| 'irradiance': ['Irradiance', 'W/m2', 'mdi:sunglasses'], | ||
| 'precipitation_forecast_average': ['Precipitation forecast average', | ||
| 'mm/h', 'mdi:weather-pouring'], | ||
| 'precipitation_forecast_total': ['Precipitation forecast total', |
| 'windgust': ['Wind gust', 'm/s', 'mdi:weather-windy'], | ||
| 'precipitation': ['Precipitation', 'mm/h', 'mdi:weather-pouring'], | ||
| 'irradiance': ['Irradiance', 'W/m2', 'mdi:sunglasses'], | ||
| 'precipitation_forecast_average': ['Precipitation forecast average', |
Member
|
Great! 🐬 |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…-assistant#8171) * Added precipitation forecast average & total sensors * Fixed some code style issues * Fixed some code style issues * Minor fix default timeframe * Update buienradar.py * Update buienradar.py
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added precipitation forecast average & total sensors to the buienradar components, which are available since buienradar==0.6.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2878
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass