Fix lifx.set_state so it works with kelvin and color_temp_kelvin and color names#81515
Conversation
… parameters Signed-off-by: Avi Miller <me@dje.li>
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Not sure if this is related, but ever since the HAC 2022.11.0 and the latest LIFX latest firmware updates (which happened on the same day) I cannot get lifx.set_state to set the brightness and/or colors. There is nothing in the logs to indicate any problem. Will this fix also fix these issues or should I open another bug report? |
|
This should fix that too. It's working for me with the new firmware. If it doesn't, open a new bug after this fix is released. |
Signed-off-by: Avi Miller <me@dje.li>
bdraco
left a comment
There was a problem hiding this comment.
Please see the comments for the new commit
Including a couple of new tests. Signed-off-by: Avi Miller <me@dje.li>
|
Thanks @Djelibeybi |
|
Thank you @Djelibeybi! :) |
Proposed change
After the change to kelvin as default color temp unit, the
lifx.set_statestopped acceptingkelvinas a parameter. We also stopped processing color names when we dropped the call topreprocess_turn_on_alternativeswhich is now restored as well. I added a bunch of tests forlifx.set_statetoo.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: