Support for the PiFace Digital I/O module#7494
Merged
Merged
Conversation
Contributor
|
Hi @basschipper, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
@basschipper, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
houndci-bot
reviewed
May 8, 2017
| """Activate the registered listener events.""" | ||
| # pylint: disable=global-variable-not-assigned | ||
| global LISTENER | ||
| LISTENER.activate() No newline at end of file |
pvizeli
previously requested changes
May 9, 2017
| For more details about this component, please refer to the documentation at | ||
| https://home-assistant.io/components/rpi_pfio/ | ||
| """ | ||
| # pylint: disable=import-error |
| LISTENER = None | ||
|
|
||
|
|
||
| # pylint: disable=no-member |
|
|
||
| DOMAIN = 'rpi_pfio' | ||
|
|
||
| LISTENER = None |
Member
There was a problem hiding this comment.
Don't use global variable. Use hass.data.
Like:
DATA_PIFACE = 'piface'
...
hass.data[DATA_PIFACE] = xy
| }) | ||
|
|
||
|
|
||
| # pylint: disable=unused-argument |
| self._name = name or DEVICE_DEFAULT_NAME | ||
| self._invert_logic = invert_logic | ||
| self._state = False | ||
| # rpi_pfio.setup_output(self._port) |
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Support for the PiFace Digital I/O module (Raspberry Pi add on board)
This is basically a port of the rpi_gpio component.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2597
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass