Add Kira component to sensor and remote platforms#7479
Conversation
|
@stu-gott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @happyleavesaoc to be potential reviewers. |
There was a problem hiding this comment.
continuation line under-indented for visual indent
There was a problem hiding this comment.
continuation line under-indented for visual indent
There was a problem hiding this comment.
continuation line unaligned for hanging indent
There was a problem hiding this comment.
continuation line unaligned for hanging indent
There was a problem hiding this comment.
Please don't use global. Use hass.data instead, it's a dictionary that you can store data in.
There was a problem hiding this comment.
Will this start a thread per sensor ?
There was a problem hiding this comment.
This will, however the large majority of installations will require only one sensor as all Kira modules can usually send to the same UDP port. The only time a user would ever need to configure more than one is to distinguish between the same IR code sent to different Kira Modules.
There was a problem hiding this comment.
This is already the default implementation, no need to overwrite it
There was a problem hiding this comment.
Ah! good catch. The original iteration of this class derived from the base remote class which is a ToggleEntity.
There was a problem hiding this comment.
No need to overwrite this if you already overwrite async_turn_off. (which is faster so better.) Same for turn_on
There was a problem hiding this comment.
continuation line over-indented for visual indent
There was a problem hiding this comment.
continuation line over-indented for visual indent
There was a problem hiding this comment.
continuation line over-indented for visual indent
There was a problem hiding this comment.
line too long (85 > 79 characters)
There was a problem hiding this comment.
module level import not at top of file
redefinition of unused 'CONF_DEVICE' from line 7
There was a problem hiding this comment.
'homeassistant.loader.get_component' imported but unused
There was a problem hiding this comment.
'homeassistant.loader.get_component' imported but unused
There was a problem hiding this comment.
continuation line under-indented for visual indent
There was a problem hiding this comment.
continuation line under-indented for visual indent
ghost
removed
6 participants
Description:
Support for Kira (Keene Electronics IR-IP bridge)
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools: