Skip to content

Remove duplicate Home Connect dishwasher program#69734

Merged
farmio merged 1 commit into
home-assistant:devfrom
golles:patch-1
Apr 14, 2022
Merged

Remove duplicate Home Connect dishwasher program#69734
farmio merged 1 commit into
home-assistant:devfrom
golles:patch-1

Conversation

@golles
Copy link
Copy Markdown
Contributor

@golles golles commented Apr 9, 2022

Fixes #69446

Proposed change

Remove the duplicate program that was introduced in this 2 commits:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • Documentation added/updated for www.home-assistant.io
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • The code has been formatted using Black (black --fast homeassistant tests)

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@BraveChicken1 BraveChicken1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Is this save to add it to a bugfix release (2022.4.4)?

@DavidMStraub
Copy link
Copy Markdown
Contributor

IMO yes.

@farmio farmio added this to the 2022.4.4 milestone Apr 14, 2022
@farmio farmio changed the title Remove duplicate program (home_connect dishwasher) Remove duplicate Home Connect dishwasher program Apr 14, 2022
@farmio farmio merged commit 8886f1c into home-assistant:dev Apr 14, 2022
@golles golles deleted the patch-1 branch April 14, 2022 12:34
@golles
Copy link
Copy Markdown
Contributor Author

golles commented Apr 14, 2022

Thank you @farmio

balloob pushed a commit that referenced this pull request Apr 14, 2022
@balloob balloob mentioned this pull request Apr 14, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform home_connect does not generate unique IDs

6 participants