Round current temperature#6954
Closed
aufano wants to merge 2 commits into
Closed
Conversation
|
@aufano, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @balloob and @fabaff to be potential reviewers. |
Contributor
houndci-bot
reviewed
Apr 6, 2017
| # Current Temp | ||
| if self.values.temperature: | ||
| self._current_temperature = self.values.temperature.data | ||
| self._current_temperature = (round((float(self.values.temperature.data)), 1)) |
Member
|
How many decimal places did this variable show? |
Member
|
It's not up to platforms to round. Rounding is already done at the component level: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/climate/__init__.py#L415-L416 |
Contributor
Author
Member
|
The fix was in the wrong place. Data has to be rounded on the component level and not the platform level. |
Contributor
Author
|
Ah ok!, I will fix the component level in #6960 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Now the variable current_temperature is rounded.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass