Conversation
houndci-bot
reviewed
Mar 28, 2017
| """Today total energy usage in kWh.""" | ||
| if self.insight_params: | ||
| return convert(self.insight_params['todaymw'], float, 0.0) / 1000.0 | ||
| return convert(self.insight_params['todaymw'], float, 0.0) / 1000000.0 |
There was a problem hiding this comment.
line too long (82 > 79 characters)
Contributor
|
This was certainly wrong - but don't think this completely fixes it. Hadn't finished digging - but I think wemo reports this in milliwatt minutes. So I think we probably also need to multiply by 60. |
Member
Author
|
@pavoni I'm not sure I understand. That'll turn this calculation into 537 kW which is also very wrong. |
Contributor
|
Sorry my description was wrong |
Member
Author
|
@pavoni that looks much better, 0.14kW. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Conversion was wrong.
8954105 mW should convert to 8.954105 kW, not 8954.105 kW.