Add NVR support to Hikvision Binary Sensors#6807
Merged
Merged
Conversation
|
@mezz64, thanks for your PR! By analyzing the history of the files in this pull request, we identified @titilambert, @balloob and @fabaff to be potential reviewers. |
pvizeli
approved these changes
Mar 27, 2017
Member
|
Good work |
Merged
ghost
added
integration: hikvision
and removed
platform: binary_sensor.hikvision
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update hikvision binary sensor platform to support Hikvision NVR devices in addition to individual cameras.
This PR also removes the "IO Sensor" type, but it does so because it was not reliable in previous builds and is difficult to make it so over the large range of hikvision models.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2340
Example entry for
configuration.yaml(if applicable):Unchanged.
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.