Skip to content

Add optional unit of measurement #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabaff merged 1 commit into from
Mar 26, 2017
Merged

Add optional unit of measurement #6796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions homeassistant/components/sensor/random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

import homeassistant.helpers.config_validation as cv
from homeassistant.components.sensor import PLATFORM_SCHEMA
from homeassistant.const import (CONF_NAME, CONF_MINIMUM, CONF_MAXIMUM)
from homeassistant.const import (
CONF_NAME, CONF_MINIMUM, CONF_MAXIMUM, CONF_UNIT_OF_MEASUREMENT)
from homeassistant.helpers.entity import Entity

_LOGGER = logging.getLogger(__name__)
Expand All @@ -26,6 +27,7 @@
vol.Optional(CONF_MAXIMUM, default=DEFAULT_MAX): cv.positive_int,
vol.Optional(CONF_MINIMUM, default=DEFAULT_MIN): cv.positive_int,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_UNIT_OF_MEASUREMENT): cv.string,
})


Expand All @@ -35,19 +37,21 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None):
name = config.get(CONF_NAME)
minimum = config.get(CONF_MINIMUM)
maximum = config.get(CONF_MAXIMUM)
unit = config.get(CONF_UNIT_OF_MEASUREMENT)

async_add_devices([RandomSensor(name, minimum, maximum)], True)
async_add_devices([RandomSensor(name, minimum, maximum, unit)], True)
return True


class RandomSensor(Entity):
"""Representation of a Random number sensor."""

def __init__(self, name, minimum, maximum):
def __init__(self, name, minimum, maximum, unit_of_measurement):
"""Initialize the sensor."""
self._name = name
self._minimum = minimum
self._maximum = maximum
self._unit_of_measurement = unit_of_measurement
self._state = None

@property
Expand All @@ -65,6 +69,11 @@ def icon(self):
"""Icon to use in the frontend, if any."""
return ICON

@property
def unit_of_measurement(self):
"""Return the unit this state is expressed in."""
return self._unit_of_measurement

@asyncio.coroutine
def async_update(self):
"""Get a new number and updates the states."""
Expand Down