Skip to content

history_stats: Fix schema check for state, as it can be arbitrary string#6734

Closed
leppa wants to merge 1 commit into
home-assistant:masterfrom
leppa:history_stats
Closed

history_stats: Fix schema check for state, as it can be arbitrary string#6734
leppa wants to merge 1 commit into
home-assistant:masterfrom
leppa:history_stats

Conversation

@leppa
Copy link
Copy Markdown
Contributor

@leppa leppa commented Mar 21, 2017

Some components may have states that are arbitrary strings (e.g., "Scattered Showers" in sensor.yweather_current). Currently it's impossible to track such components with history_stats sensor.

@mention-bot
Copy link
Copy Markdown

@leppa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bokub, @balloob and @kellerza to be potential reviewers.

@homeassistant homeassistant added cla-signed merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. platform: sensor.history_stats labels Mar 21, 2017
@andrey-git
Copy link
Copy Markdown
Contributor

@leppa you should make the PR against the dev branch, not against the master branch

@leppa
Copy link
Copy Markdown
Contributor Author

leppa commented Mar 23, 2017

@andrey-git, but I consider this a bugfix. Shouldn't bugfixes go into master?

@andrey-git
Copy link
Copy Markdown
Contributor

If a bugfix should go into a minor release it still goes to dev and marked with appropriate milestone.

There are biweekly releases. The next one is on Saturday.

@leppa
Copy link
Copy Markdown
Contributor Author

leppa commented Mar 23, 2017

Ah, ok. Thanks for the explanation. I'll resubmit my change on top of dev then.

@leppa leppa closed this Mar 23, 2017
@leppa
Copy link
Copy Markdown
Contributor Author

leppa commented Mar 23, 2017

New PR: #6753

@home-assistant home-assistant locked and limited conversation to collaborators Jun 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: history_stats merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants