Skip to content

Fix Squeezebox discovery#6525

Merged
balloob merged 1 commit into
devfrom
fix_squeezebox_discovery
Mar 11, 2017
Merged

Fix Squeezebox discovery#6525
balloob merged 1 commit into
devfrom
fix_squeezebox_discovery

Conversation

@pavoni
Copy link
Copy Markdown
Contributor

@pavoni pavoni commented Mar 11, 2017

Description:

At least on my system the discovery_info is a dictionary - rather than array.

This used to work - and broke a couple of releases ago.

Did the format from netdisco change?

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@pavoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @persandstrom and @dasos to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 11, 2017

I know that for netdisco that we're working on migrating to hashes, guess we didn't update the discovery in HASS when changing the netdisco side.

Thanks 🐬

@balloob balloob merged commit 32dd815 into dev Mar 11, 2017
@balloob balloob deleted the fix_squeezebox_discovery branch March 11, 2017 18:39
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 11, 2017

cherry-picked for 0.40

@balloob balloob mentioned this pull request Mar 24, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants