Append vera device id to entity id - but not name.#6523
Merged
Conversation
|
@pavoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @robjohnson189 and @jamespcole to be potential reviewers. |
houndci-bot
reviewed
Mar 11, 2017
|
|
||
| # Append device id to prevent name clashes in HA. | ||
| self._name = self.vera_device.name + ' ' + str(vera_device.device_id) | ||
| self.vera_id = VERA_ID_FORMAT.format(slugify(vera_device.name), vera_device.device_id) |
There was a problem hiding this comment.
line too long (94 > 79 characters)
8 tasks
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good. Nitpicking, I would say that we only use explicit brackets (for tuple) when importing and the imports extend over one line. If imports stay on one line, it's not necessary. Also imports could be alphabetically sorted, also within the same tuple.
Contributor
Author
|
Thanks @MartinHjelmare hopefully sorted. |
MartinHjelmare
approved these changes
Mar 11, 2017
Member
|
Perfect 🐬 |
balloob
pushed a commit
that referenced
this pull request
Mar 11, 2017
* Append vera device id to entity id - but not name. * Tidy. * Tidy. * Tidy after review. * Re-order.
Member
|
cherry-picked for 0.40 |
Merged
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix problem in #6100 (comment) that appended the device ids to the name as well as the entity_id.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass