Skip to content

Fix Wemo create task for awaitable#62159

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
esev:fix_awaitable
Dec 17, 2021
Merged

Fix Wemo create task for awaitable#62159
MartinHjelmare merged 1 commit into
home-assistant:devfrom
esev:fix_awaitable

Conversation

@esev
Copy link
Copy Markdown
Contributor

@esev esev commented Dec 17, 2021

Breaking change

Small bug fix to use hass.create_task rather than hass.add_job for an Awaitable.

Found while working on fixing type checking in #62157. Figured it'd be best to split this change from that PR to keep each PR limited to a single purpose.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Wemo bugfix: Use hass.create_task for Awaitable Fix Wemo create task for awaitable Dec 17, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit d874eb2 into home-assistant:dev Dec 17, 2021
@esev esev deleted the fix_awaitable branch December 17, 2021 16:37
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants