QNAP update#6182
Merged
Merged
Conversation
This sitaution will usually occur if the server configuration is wrong or the timeout is set too low. In both cases `api.update()` will fail, which is a problem because we cannot initialize many of the sensors without having this data.
|
@colinodell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers. |
This was referenced Feb 23, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Several small enhancements to the QNAP sensor:
Library Version Bump
Bumps underlying library version to 0.2.3, which fixes compatibility issues with some QNAP devices.
New
timeoutsettingThe underlying library now supports a configurable timeout. This is needed because some lower-end models are slower and therefore need more time to supply their data. (If the first API data update fails, this setup process of this sensor will fail)
Persistent notification on sensor setup failure
If the sensor setup fails to obtain the necessary API data (usually due to a timeout or incorrect server settings), it now shows a persistent notification. This behavior was mirrored from the Amcrest component, which also requires API data during setup.
New
system_tempconditionHASS users can now monitor the system temperature of their QNAP device.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2112
Example entry for
configuration.yaml(if applicable):Here's a minimal configuration showing the new
timeoutandsystem_tempoptions:Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.