Skip to content

QNAP update#6182

Merged
fabaff merged 4 commits into
home-assistant:devfrom
colinodell:qnap-update
Feb 23, 2017
Merged

QNAP update#6182
fabaff merged 4 commits into
home-assistant:devfrom
colinodell:qnap-update

Conversation

@colinodell
Copy link
Copy Markdown
Contributor

@colinodell colinodell commented Feb 23, 2017

Description:

Several small enhancements to the QNAP sensor:

Library Version Bump

Bumps underlying library version to 0.2.3, which fixes compatibility issues with some QNAP devices.

New timeout setting

The underlying library now supports a configurable timeout. This is needed because some lower-end models are slower and therefore need more time to supply their data. (If the first API data update fails, this setup process of this sensor will fail)

Persistent notification on sensor setup failure

If the sensor setup fails to obtain the necessary API data (usually due to a timeout or incorrect server settings), it now shows a persistent notification. This behavior was mirrored from the Amcrest component, which also requires API data during setup.

New system_temp condition

HASS users can now monitor the system temperature of their QNAP device.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2112

Example entry for configuration.yaml (if applicable):

Here's a minimal configuration showing the new timeout and system_temp options:

  - platform: qnap
    host: 192.168.1.10
    ssl: false
    timeout: 15
    username: admin
    password: correcthorsebatterystaple
    monitored_conditions:
      - system_temp

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

This sitaution will usually occur if the server configuration is wrong or the
timeout is set too low.  In both cases `api.update()` will fail, which is a
problem because we cannot initialize many of the sensors without having this
data.
@mention-bot
Copy link
Copy Markdown

@colinodell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 89807f2 into home-assistant:dev Feb 23, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants