From b7683991f40d35d31f46d0329e669cc0744067e8 Mon Sep 17 00:00:00 2001 From: Jason Lawrence Date: Wed, 19 May 2021 08:59:24 -0500 Subject: [PATCH 1/2] Use common firmware version in Sonos device info --- homeassistant/components/sonos/speaker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/sonos/speaker.py b/homeassistant/components/sonos/speaker.py index e647fc2fd68aea..6d411d1cb187ca 100644 --- a/homeassistant/components/sonos/speaker.py +++ b/homeassistant/components/sonos/speaker.py @@ -146,7 +146,7 @@ def __init__( self.mac_address = speaker_info["mac_address"] self.model_name = speaker_info["model_name"] - self.version = speaker_info["software_version"] + self.version = speaker_info["display_version"] self.zone_name = speaker_info["zone_name"] self.battery_info: dict[str, Any] | None = None From ad523c2cb3d72e971f17284b8aefb96e1204395f Mon Sep 17 00:00:00 2001 From: Jason Lawrence Date: Wed, 19 May 2021 09:07:21 -0500 Subject: [PATCH 2/2] Update tests --- tests/components/sonos/conftest.py | 1 + tests/components/sonos/test_media_player.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/components/sonos/conftest.py b/tests/components/sonos/conftest.py index f22c462f8818dc..79e44720591528 100644 --- a/tests/components/sonos/conftest.py +++ b/tests/components/sonos/conftest.py @@ -83,6 +83,7 @@ def speaker_info_fixture(): "model_name": "Model Name", "software_version": "49.2-64250", "mac_address": "00-11-22-33-44-55", + "display_version": "13.1", } diff --git a/tests/components/sonos/test_media_player.py b/tests/components/sonos/test_media_player.py index 460c9012aebf64..cba6967463abaa 100644 --- a/tests/components/sonos/test_media_player.py +++ b/tests/components/sonos/test_media_player.py @@ -63,7 +63,7 @@ async def test_device_registry(hass, config_entry, config, soco): identifiers={("sonos", "RINCON_test")} ) assert reg_device.model == "Model Name" - assert reg_device.sw_version == "49.2-64250" + assert reg_device.sw_version == "13.1" assert reg_device.connections == {(dr.CONNECTION_NETWORK_MAC, "00:11:22:33:44:55")} assert reg_device.manufacturer == "Sonos" assert reg_device.suggested_area == "Zone A"