Add Android TV screen capture option and use library screencap

[i00]

Breaking change

None

Proposed change

Add attribute option to turn off screen captures for Android TV; for devices that have permanent HDCP (hdmi protection) or slow screen updates.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
media_player:
  - platform: androidtv
    #Existing options here
    screencap: false

Additional information

• This PR fixes or closes issue: entity_picture of the AndroidTV integration is a flashing black dot #34018
• This PR is related to issue:
• Link to documentation pull request: Update Android TV docs home-assistant.io#12850

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @JeffLIrion, mind taking a look at this pull request as its been labeled with a integration (androidtv) you are listed as a codeowner for? Thanks!

[JeffLIrion]

You need to bump the requirements in requirements_test_all.txt (I think that's the right filename).

[JeffLIrion]

You should make the title more descriptive.

Also, you'll need a test to pass the coverage check. You can use this: a0e145f. You might need more.

[i00]

@JeffLIrion ... sorry can you explain why the tests are failing ... even without code coverage; I believe it should have passed ... correct me if I am wrong; but it appears that the issues relate to other things that are already in the dev branch?

[JeffLIrion]

@JeffLIrion ... sorry can you explain why the tests are failing ... even without code coverage; I believe it should have passed ... correct me if I am wrong; but it appears that the issues relate to other things that are already in the dev branch?

Bad luck😉

Either push another commit or close and re-open the pull request.

[i00]

Also, you'll need a test to pass the coverage check. You can use this: a0e145f. You might need more.

Also (this may seem a little dumb ... but) where is that commit located ... when i fetch the upstream then run
git branch --contains a0e145f
it says the commit doesn't eixst.

[JeffLIrion]

Also, you'll need a test to pass the coverage check. You can use this: a0e145f. You might need more.

Also (this may seem a little dumb ... but) where is that commit located ... when i fetch the upstream then run
git branch --contains a0e145f
it says the commit doesn't eixst.

It's on my fork. You could either add my fork as a git remote, or you could just copy & paste the whole file.

https://github.com/JeffLIrion/home-assistant/blob/patch-37/tests/components/androidtv/test_media_player.py

[springstan]

LGTM ✌