Skip to content

Config flow for elkm1#33297

Merged
bdraco merged 4 commits into
home-assistant:devfrom
bdraco:elkm1_configflow
Mar 27, 2020
Merged

Config flow for elkm1#33297
bdraco merged 4 commits into
home-assistant:devfrom
bdraco:elkm1_configflow

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 27, 2020

Breaking change

  • As entity ids can now be changed, the “alarm_control_panel”
    attribute “changed_by_entity_id” is now “changed_by_keypad”
    and will show the name of the Elk keypad instead of the entity id.

Proposed change

  • An auto configure mode has been introduced which avoids the
    need to setup the complex include and exclude filters. This
    functionality still exists when configuring from yaml for power
    users who want more control over which entities elkm1 generates.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* As entity ids can now be changed, the “alarm_control_panel”
attribute “changed_by_entity_id” is now “changed_by_keypad”
and will show the name of the Elk keypad instead of the entity id.

* An auto configure mode has been introduced which avoids the
need to setup the complex include and exclude filters.  This
functionality still exists when configuring from yaml for power
users who want more control over which entities elkm1 generates.
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 27, 2020

@gjbadros If you have a spare moment, would you give this a spin?

Comment thread homeassistant/components/elkm1/__init__.py
Comment thread homeassistant/components/elkm1/__init__.py
Comment thread homeassistant/components/elkm1/__init__.py
Comment thread homeassistant/components/elkm1/config_flow.py
@gjbadros
Copy link
Copy Markdown
Contributor

gjbadros commented Mar 27, 2020 via email

Comment thread homeassistant/components/elkm1/alarm_control_panel.py Outdated
Comment thread homeassistant/components/elkm1/config_flow.py
@bdraco bdraco merged commit 18a4829 into home-assistant:dev Mar 27, 2020
Comment thread homeassistant/components/elkm1/__init__.py
Comment thread tests/components/elkm1/test_config_flow.py
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elk M1 integration problems

6 participants