Allow ZHA device creation for the Zigbee coordinator#31032
Merged
dmulcahey merged 3 commits intoJan 21, 2020
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
Adminiuga
approved these changes
Jan 20, 2020
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Looks good. The only question: should we allow a really determined user to remove coordinator using zha.remove service ?
Contributor
Author
|
Argh I’ll protect that one too |
Contributor
|
well, it is not that you can accidentally remove it. For |
Contributor
Author
|
Agreed, I’ll do it in a bit. |
Contributor
Author
|
ok I am confused.... I already did it... |
Contributor
|
yep, I guess I missed the very 1st file 🤦♂ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the restriction that was in place preventing the creation of a ZHA device for the Zigbee coordinator. This fixes a hard error on the OOTB devices page when attempting to load device triggers and actions if someone selects the coordinator and it allows us to interact with the coordinator in group management in the ZHA configuration panel
DO NOT MERGE WITHOUT UI PR: home-assistant/frontend#4541
Checklist:
tox. Your PR cannot be merged unless tests pass