Skip to content

Update service domains for xiaomi_miio from base domains to xiaomi_miio domain#29134

Merged
balloob merged 11 commits into
home-assistant:devfrom
raman325:xiaomi_miio_service_update
Dec 2, 2019
Merged

Update service domains for xiaomi_miio from base domains to xiaomi_miio domain#29134
balloob merged 11 commits into
home-assistant:devfrom
raman325:xiaomi_miio_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the services defined in the xiaomi_miio integration by moving the services out of the base domains into the integration domain.

Description:

Update the domain and service name for xiaomi_miio services. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): 11330

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration (xiaomi_miio) you are listed as a codeowner for? Thanks!

@raman325
Copy link
Copy Markdown
Contributor Author

resolved conflicts, this is due to me changing this file in multiple branches and another PR that came in for this component

@rytilahti
Copy link
Copy Markdown
Member

This is great, thanks for doing the work! In case no one else appears to test these, I'll try to do so over the weekend and get this merged then.

Comment thread homeassistant/components/xiaomi_miio/const.py Outdated
…325/home-assistant into xiaomi_miio_service_update

* 'xiaomi_miio_service_update' of https://github.com/raman325/home-assistant: (41 commits)
  Add fan support to lutron_caseta (#29033)
  Update service domain for alarmdecoder from 'alarm_control_panel' to 'alarmdecoder' (#29127)
  move wemo services to wemo domain (#29135)
  move soundtouch services to soundtouch domain (#29140)
  [ci skip] Translation update
  add services.yaml description for service (#29160)
  Update bluetooth_tracker service name and domain from 'device_tracker' to 'bluetooth_tracker' (#29161)
  Change apns service domain and remove unused variable (#29165)
  Handle case when device can be None (#29171)
  Reduce connection timeout to avoid config flow timeouts (#29172)
  move import to top and add service definition for pilight (#29163)
  Return Jewish Calendar holiday type id support (#29168)
  Use roku.poweron method for media_player.turn_on (#29123)
  Update service domain for ifttt from 'alarm_control_panel' to 'ifttt' (#29129)
  add services.yaml description for matrix service (#29159)
  Update service domain for harmony from 'remote' to 'harmony' (#29146)
  move yamaha service to yamaha domain (#29142)
  Update services.yaml for nuheat (#29133)
  Add opentherm_gw device support (#28722)
  move squeezebox service to squeezebox domain (#29141)
  ...
@raman325
Copy link
Copy Markdown
Contributor Author

raman325 commented Dec 2, 2019

@rytilahti please review/test if you haven't already. I made a lot of service changes across a significant number of integrations and this is the only one remaining. I think it would be best to release all of the breaking changes in one release so that users only feel the pain once, and I don't want this one to miss the cutoff.

CC @balloob

@balloob balloob merged commit 040fd9c into home-assistant:dev Dec 2, 2019
@lock lock Bot locked and limited conversation to collaborators Dec 3, 2019
@raman325 raman325 deleted the xiaomi_miio_service_update branch December 3, 2019 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants