Skip to content

Update services.yaml for nuheat#29133

Merged
frenck merged 4 commits into
home-assistant:devfrom
raman325:nuheat_service_update
Nov 27, 2019
Merged

Update services.yaml for nuheat#29133
frenck merged 4 commits into
home-assistant:devfrom
raman325:nuheat_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 27, 2019

Breaking Change:

N/A

Description:

resume_program was already in the nuheat domain but the services.yaml entry was in the climate domain, so moved the service entry over

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11308

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 27, 2019

@raman325 Could you resolve the conflict on this one?

@raman325
Copy link
Copy Markdown
Contributor Author

resolved, this is due to me changing this file in multiple branches

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @raman325! Looks good to me!

@frenck frenck merged commit ef21fd2 into home-assistant:dev Nov 27, 2019
@raman325 raman325 deleted the nuheat_service_update branch November 27, 2019 15:07
@lock lock Bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants