Update service domain for alarmdecoder from 'alarm_control_panel' to 'alarmdecoder'#29127
Merged
balloob merged 5 commits intoNov 28, 2019
Conversation
probot-home-assistant
Bot
added
core
integration: alarmdecoder
small-pr
2 tasks
Santobert
approved these changes
Nov 27, 2019
Member
Santobert
left a comment
Santobert
left a comment
There was a problem hiding this comment.
Looks good to me. Please solve the merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
This change breaks existing service call references to the
alarm_control_panel.alarmdecoder_alarm_toggle_chimeservices by changing the service calls to bealarmdecoder.alarm_toggle_chime. My understanding is that because this is not a service provided by the basealarm_control_panelcomponent, it should live in the domain of thealarmdecodercomponent instead. If that's the case, then it also makes sense to update the service name.Description:
Update the domain and service name for
alarmdecoder.alarm_toggle_chime. See this comment for context: #28890 (comment)Related issue (if applicable): Related to #27289
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11304
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.