Fix connection issues with withings API by switching to a maintained codebase#27310
Merged
MartinHjelmare merged 3 commits intoOct 8, 2019
Conversation
…ed client codebase.
probot-home-assistant
Bot
added
Hacktoberfest
has-tests
integration: withings
small-pr
balloob
approved these changes
Oct 8, 2019
Member
|
Ok to merge when you run |
MartinHjelmare
changed the title
MartinHjelmare
approved these changes
Oct 8, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Can be merged when build passes.
Member
|
Should this go into 0.100? |
Contributor
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
No breaking changes.
Description:
Shortly after inclusion into home assistant, the withings API started requiring extra data when authorizing. The client code the withings component uses was maintained. So we have switched over to a maintained api client.
Related issue (if applicable): fixes #
fixes #26716
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.