Fix Plex media_player.play_media service#27278
Merged
Merged
Conversation
Contributor
Author
|
Hey @balloob, pinging you as requested. Hoping to review and fit this into 0.100 for everyone that's waiting patiently. |
balloob
approved these changes
Oct 7, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
🎉 amazing. Tagging it for 0.100
Member
|
Nicely done @jjlawren ❤️ |
balloob
pushed a commit
that referenced
this pull request
Oct 8, 2019
* First attempt to fix play_media * More changes to media playback * Use playqueues, clean up play_media * Use similar function name, add docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix the
media_player.play_mediaservice. Some JSON parameters inmedia_content_idare now optional, which will be documented.Related issue (if applicable): fixes #19623
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#TODO
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: