Add irrigation service to rain bird#26404
Closed
peternijssen wants to merge 72 commits into
Closed
Conversation
2 tasks
Contributor
Author
|
@konikvranik since you seem to be kinda maintaining rainbird I believe, you might want to check out my MR. |
MartinHjelmare
changed the title
konikvranik
suggested changes
Sep 4, 2019
Contributor
konikvranik
left a comment
konikvranik
left a comment
There was a problem hiding this comment.
@peternijssen please, rebase onto #26393 where is upgrade to pyrainbird 0.3.1
Contributor
There was a problem hiding this comment.
Uprgade to pyrainbird v0.3.1
method names are now more pythonlike.
Contributor
There was a problem hiding this comment.
Avoid of redundance of code.
Change logic in turn_on to call start_irrigation with duration from config.
Contributor
There was a problem hiding this comment.
Also this is not true already. In pyrainbird there are returned True or False. REbase on my pullrequest #26393 where changes are made.
peternijssen
requested review from
a team,
Danielhiversen,
Jc2k,
Kane610,
OttoWinter,
awarecan,
bachya,
balloob,
danielperna84,
dgomes,
dmulcahey,
elupus,
emlove,
fabaff,
frenck,
hunterjm,
kellerza,
ludeeus,
pnbruckner,
robbiet480,
rohankapoorcom,
rytilahti,
scop,
syssi and
zxdavb
as code owners
Contributor
Author
|
Holy shit. I messed something up. |
Contributor
Author
|
Let me close this and get a proper fix. Sorry once again :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
It's great that you can turn on your irrigation through home assistant. The annoying part I had with Rain Bird is that you have to set the duration up front within the config. This means that if you want to do a different duration, you have to reload home assistant. With this change, a new service is being added, allowing you to send along the duration.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10288
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: